Allow providing a pull secret for the plugin daemonsets #2074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tuomas Katila <tuomas.katila@intel.com>
Signed-off-by: Tuomas Katila <tuomas.katila@intel.com>
tkatila
requested review from
mythi,
bart0sh,
ozhuraki and
hj-johannes-lee
as code owners
mythi
reviewed
Jun 17, 2025
| @@ -94,6 +94,12 @@ type DevicePluginController interface { | |||
| Upgrade(ctx context.Context, obj client.Object) (upgrade bool) | |||
| } | |||
|
|
|||
| type ControllerArgs struct { | |||
There was a problem hiding this comment.
Suggested change
| type ControllerArgs struct { | |
| type ControllerOptions struct { |
| @@ -94,6 +94,12 @@ type DevicePluginController interface { | |||
| Upgrade(ctx context.Context, obj client.Object) (upgrade bool) | |||
| } | |||
|
|
|||
| type ControllerArgs struct { | |||
| Namespace string | |||
| Secret string | |||
There was a problem hiding this comment.
Suggested change
| Secret string | |
| ImagePullSecretName string |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change is split into two commits, one adding the support to provide the secrets, and another to restructure how data is passed to the controllers. The restructuring can be dropped or the two can be merged.
Fixes ##1981